Collision Filters Still having some problems

mmk.verheijden · May 21, 2013, 8:32pm

oky so if i understand this is correct ?

function newCollisionHandler( self, event ) &nbsp; &nbsp;print("oh hello i have a Collision") &nbsp; &nbsp;if randomStar.myName == "BCloud1" then &nbsp; &nbsp; &nbsp; &nbsp; print("Collided with star1") &nbsp; &nbsp;elseif event.other.randomStar.myName == "BCloud2" then &nbsp; &nbsp; &nbsp; &nbsp; print("Collided with star2") &nbsp; &nbsp;elseif event.other.randomStar.myName == "BCloud3" then &nbsp; &nbsp; &nbsp; &nbsp; print("Collided with star3") &nbsp; &nbsp;end end &nbsp;

bjsorrentino · May 21, 2013, 8:44pm

Not exactly… in a “local-style” collision, one object is represented by “self” and the other by “event.other”. Those are the direct references to the two objects involved in the collision, so you should deal with them at that level.

mmk.verheijden · May 13, 2013, 9:57am

Hi Andrew

line 296 is: player:addEventListener( “collision”, newCollisionHandler )

playerSpriteSheet = sprite.newSpriteSheet("player.png", 113, 55) playerSprites = sprite.newSpriteSet(playerSpriteSheet, 1, 4) sprite.add(playerSprites, "players", 1, 4, 1000, 0) player = sprite.newSprite(playerSprites) local newCollisionHandler player:addEventListener( "collision", newCollisionHandler ) player.x = -80 player.y = 350 player:prepare("players") player:play() player.collided = false player:setReferencePoint(display.CenterReferencePoint); physics.addBody(player, "static", {density=.1, bounce=0.1, friction=.2, radius=10, filter=playerCollisionFilter } ) player.gravityScale = 0 screenGroup:insert(player) playerIntro = transition.to(player,{time=2000, x=150, onComplete=playerReady}) &nbsp;

Regards Kevin,

aukStudios · May 13, 2013, 2:08pm

Hi Kevin,

Looks like the problem is that newCollisionHandler is in fact nil. The line 295 “local newCollisionHandler” sets up newCollisionHandler as a local variable with a default value of nil. You then immediately try to add it as a collision listener to the player object, but since it’s nil, you’ll get an error. Instead, you need to first define newCollisionHandler as a function, and then add it as a listener. It looks like from your original post, you may have defined newCollisionHandler as a global function, but the line “local newCollisionHandler” will overwrite that, rescoping newCollisionHandler as local and giving it a default value of nil.

See some of the samples here: http://developer.coronalabs.com/content/game-edition-collision-detection

Hope this helps.

Andrew

mmk.verheijden · May 13, 2013, 2:56pm

Hi Andrew,

so when i try this :

&nbsp;&nbsp; &nbsp;function newCollisionHandler() &nbsp; &nbsp; &nbsp;&nbsp;playeraddEventListener( "collision", newCollisionHandler ) &nbsp;&nbsp;&nbsp;&nbsp;end

The errors go but now its not detecting any collisions.

-Kevin

aukStudios · May 13, 2013, 3:03pm

Hi Kevin,

Looks like there are two issues with what you pasted there. First, there’s a colon missing between “player” and “addEventListener”. But more importantly, you’re defining newCollisionHandler as a function which adds itself(?) as a collision listener.

I’d suggest taking a close look at the example called “Local collision listeners” on this page: http://developer.coronalabs.com/content/game-edition-collision-detection

A quick look at your original post, and nothing is jumping out at me as wrong except that you define newCollisionHandler after you attempt to add as a listener. You need to define the function before. In your original post, just move the line “player:addEventListener( “collision”, newCollisionHandler )” below where you define the newCollisionHandler function.

Andrew

mmk.verheijden · May 13, 2013, 3:10pm

Oky thanks Andrew,

i will have a look at it

-kevin

mmk.verheijden · May 13, 2013, 6:46pm

oky so from you comments Andrew i have done this :

badc1CollisionFilter = { categoryBits = 1, maskBits = 16 } badc2CollisionFilter = { categoryBits = 2, maskBits = 16 } badc3CollisionFilter = { categoryBits = 4, maskBits = 16 } wallCollisionFilter = { categoryBits = 8, maskBits = 16 } playerCollisionFilter = { categoryBits = 16, maskBits = 15 } function getRandomStar() &nbsp;&nbsp;&nbsp;&nbsp;local temp = starTable[math.random(1, #starTable)] -- Get a random star from starTable &nbsp;&nbsp;&nbsp;&nbsp;local randomStar = display.newImage(temp.imgpath) -- Set image path for object &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;if ( temp.imgpath == "BCloud1.png" ) then &nbsp;&nbsp;&nbsp;&nbsp;physics.addBody( randomStar, { density=.1, bounce=0.1, friction=.2, radius=45, filter=badc1CollisionFilter } ) &nbsp;&nbsp;&nbsp;&nbsp;randomStar.myName = "star1" &nbsp;&nbsp;&nbsp;&nbsp;temp.imgpath = "BCloud"..tostring(math.random(1, 3))..".png"; &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;if ( temp.imgpath == "BCloud2.png" ) then &nbsp;&nbsp;&nbsp;&nbsp;physics.addBody( randomStar, { density=.1, bounce=0.1, friction=.2, radius=45, filter=badc2CollisionFilter } ) &nbsp;&nbsp;&nbsp;&nbsp;randomStar.myName = "star2" &nbsp;&nbsp;&nbsp;&nbsp;temp.imgpath = "BCloud"..tostring(math.random(1, 3))..".png"; &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;if ( temp.imgpath == "BCloud3.png" ) then &nbsp;&nbsp;&nbsp;&nbsp;physics.addBody( randomStar, { density=.1, bounce=0.1, friction=.2, radius=45, filter=badc3CollisionFilter } ) &nbsp;&nbsp;&nbsp;&nbsp;randomStar.myName = "star3" &nbsp;&nbsp;&nbsp;&nbsp;temp.imgpath = "BCloud"..tostring(math.random(1, 3))..".png"; &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;randomStar.myName = "star" -- Set the name of the object to star &nbsp;&nbsp;&nbsp;&nbsp;randomStar.movementSpeed = temp.movementSpeed; -- Set how fast the object will move &nbsp;&nbsp;&nbsp;&nbsp;randomStar.x = math.random(-30, \_W);&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;randomStar.y = -35; &nbsp;&nbsp;&nbsp;&nbsp;randomStar.rotation = math.random(0,20) -- Rotate the object &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;starMove = transition.to(randomStar, { &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;time=randomStar.movementSpeed,&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;y=500, &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;onComplete = function(self) self.parent:remove(self); self = nil;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}) -- Move the star end--END getRandomStar() &nbsp; &nbsp; playerSpriteSheet = sprite.newSpriteSheet("player.png", 113, 55) &nbsp; &nbsp; playerSprites = sprite.newSpriteSet(playerSpriteSheet, 1, 4) &nbsp; &nbsp; sprite.add(playerSprites, "players", 1, 4, 1000, 0) &nbsp; &nbsp; player = sprite.newSprite(playerSprites) &nbsp; &nbsp; player.x = -80 &nbsp; &nbsp; player.y = 350 &nbsp; &nbsp; player:prepare("players") &nbsp; &nbsp; player:play() &nbsp; &nbsp; player.collided = false &nbsp; &nbsp; player:setReferencePoint(display.CenterReferencePoint); &nbsp; &nbsp; physics.addBody(player, "static", {density=.1, bounce=0.1, friction=.2, radius=10, filter=playerCollisionFilter } ) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; player.gravityScale = 0 &nbsp; &nbsp; &nbsp; &nbsp; screenGroup:insert(player) &nbsp; &nbsp; playerIntro = transition.to(player,{time=2000, x=150, onComplete=playerReady}) function newCollisionHandler( self, event ) &nbsp; &nbsp;if event.other.myName == "star1" then &nbsp; &nbsp; &nbsp; &nbsp; print( "Collided with star1" ) &nbsp; &nbsp;elseif event.other.myName == "star2" then &nbsp; &nbsp; &nbsp; &nbsp; print( "Collided with star2" ) &nbsp; &nbsp;elseif event.other.myName == "star3" then &nbsp; &nbsp; &nbsp; &nbsp; print( "Collided with star3" ) &nbsp; &nbsp;end end function scene:enterScene(event) &nbsp; &nbsp; player:addEventListener( "collision", newCollisionHandler ) end &nbsp;

and now i got the error : attempt to index local event (a nil value).

But this time the error corespondents to the image it collides whit, (so that a good sign ?)

ps if i add ‘function newCollisionHandler() end’ to the codel like so :

 function newCollisionHandler() end &nbsp; &nbsp; playerSpriteSheet = sprite.newSpriteSheet("player.png", 113, 55) &nbsp; &nbsp; playerSprites = sprite.newSpriteSet(playerSpriteSheet, 1, 4) &nbsp; &nbsp; sprite.add(playerSprites, "players", 1, 4, 1000, 0) &nbsp; &nbsp; player = sprite.newSprite(playerSprites) &nbsp; &nbsp; player.x = -80 &nbsp; &nbsp; player.y = 350 &nbsp; &nbsp; player:prepare("players") &nbsp; &nbsp; player:play() &nbsp; &nbsp; player.collided = false &nbsp; &nbsp; player:setReferencePoint(display.CenterReferencePoint); &nbsp; &nbsp; physics.addBody(player, "static", {density=.1, bounce=0.1, friction=.2, radius=10, filter=playerCollisionFilter } ) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; player.gravityScale = 0 &nbsp; &nbsp; &nbsp; &nbsp; screenGroup:insert(player) &nbsp; &nbsp; playerIntro = transition.to(player,{time=2000, x=150, onComplete=playerReady})

its not detecting any collision

-kevin

aukStudios · May 13, 2013, 7:06pm

Hi Kevin,

When you get an error, it’ll always refer to the line number in your code it occurred on. What line number did it refer to, and which line does that correspond to in your code above?

I’m not sure I understood what you mean by your P.S.

Andrew

mmk.verheijden · May 13, 2013, 7:10pm

sorry :

if collision on star1 error is on line: “if event.other.myName == “star1” then”

if collision on star2 error is on line: “if event.other.myName == “star2” then”

if collision on star3 error is on line: “if event.other.myName == “star3” then”

from:

function newCollisionHandler( self, event )

if event.other.myName == “star1” then
print( “Collided with star1” )
elseif event.other.myName == “star2” then
print( “Collided with star2” )
elseif event.other.myName == “star3” then
print( “Collided with star3” )
end
end

-kevin

aukStudios · May 13, 2013, 7:27pm

Hi there,

In your enterScene event, try replacing

[lua]

player:addEventListener( “collision”, newCollisionHandler )

[/lua]

with

[lua]

player.collision = newCollisionHandler

player:addEventListener( “collision”, player )

[/lua]

mmk.verheijden · May 14, 2013, 11:53am

Hi Andrew,

when i do this :

function newCollisionHandler( self, event )&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;print("oh hello i have a Collision") &nbsp; &nbsp;if event.other.myName == "star1" then &nbsp; &nbsp; &nbsp; &nbsp; print( "Collided with star1" ) &nbsp; &nbsp;elseif event.other.myName == "star2" then &nbsp; &nbsp; &nbsp; &nbsp; print( "Collided with star2" ) &nbsp; &nbsp;elseif event.other.myName == "star3" then &nbsp; &nbsp; &nbsp; &nbsp; print( "Collided with star3" ) &nbsp; &nbsp;end end function scene:enterScene(event) &nbsp;&nbsp;&nbsp;&nbsp;player.collision = newCollisionHandler &nbsp;&nbsp;&nbsp;&nbsp;player:addEventListener( "collision", player ) &nbsp;

The terminal prints : ‘oh hello i have a Collision’ but not the ‘Collided with star1/2/3’ ?

-kevin

aukStudios · May 14, 2013, 1:49pm

Hi Kevin,

My suggestion would be to put the statement “print_r(event)” in your newCollisionHandler function. It’ll print out the entire contents of the event table so you can inspect it and see exactly what it’s reporting about the collision.

You can get an implementation of print_r here: http://developer.coronalabs.com/code/printr-implementation-dumps-everything-human-readable-text

Andrew

mmk.verheijden · May 14, 2013, 3:29pm

looks like it cant find the ‘myName’ in the code if i add ‘print( "test " … myName )’ to the newCollisionHandler it cant find it end trows a global ‘newCollisionHandler’ a nil value.

snip:

function getRandomStar() &nbsp;&nbsp;&nbsp;&nbsp;local temp = starTable[math.random(1, #starTable)] -- Get a random star from starTable &nbsp;&nbsp;&nbsp;&nbsp;local randomStar = display.newImage(temp.imgpath) -- Set image path for object &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;if ( temp.imgpath == "BCloud1.png" ) then &nbsp;&nbsp;&nbsp;&nbsp;local object1 =&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;physics.addBody( randomStar, { density=.1, bounce=0.1, friction=.2, radius=45, filter=badc1CollisionFilter } ) &nbsp;&nbsp;&nbsp;&nbsp;randomStar.myName = "BCloud1" &nbsp;&nbsp;&nbsp;&nbsp;temp.imgpath = "BCloud"..tostring(math.random(1, 3))..".png"; print( "BC1 print name test " .. randomStar.myName )&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;if ( temp.imgpath == "BCloud2.png" ) then &nbsp;&nbsp;&nbsp;&nbsp;physics.addBody( randomStar, { density=.1, bounce=0.1, friction=.2, radius=45, filter=badc2CollisionFilter } ) &nbsp;&nbsp;&nbsp;&nbsp;randomStar.myName = "BCloud2" &nbsp;&nbsp;&nbsp;&nbsp;temp.imgpath = "BCloud"..tostring(math.random(1, 3))..".png"; &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;if ( temp.imgpath == "BCloud3.png" ) then &nbsp;&nbsp;&nbsp;&nbsp;physics.addBody( randomStar, { density=.1, bounce=0.1, friction=.2, radius=45, filter=badc3CollisionFilter } ) &nbsp;&nbsp;&nbsp;&nbsp;randomStar.myName = "BCloud3" &nbsp;&nbsp;&nbsp;&nbsp;temp.imgpath = "BCloud"..tostring(math.random(1, 3))..".png"; &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;randomStar.myName = "star" -- Set the name of the object to star &nbsp;&nbsp;&nbsp;&nbsp;randomStar.movementSpeed = temp.movementSpeed; -- Set how fast the object will move &nbsp;&nbsp;&nbsp;&nbsp;randomStar.x = math.random(-30, \_W);&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;randomStar.y = -35; &nbsp;&nbsp;&nbsp;&nbsp;randomStar.rotation = math.random(0,20) -- Rotate the object &nbsp;&nbsp;&nbsp;&nbsp;starMove = transition.to(randomStar, { &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;time=randomStar.movementSpeed,&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;y=500, &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;onComplete = function(self) self.parent:remove(self); self = nil;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}) -- Move the star &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; end--END getRandomStar() function newCollisionHandler( self, event ) &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;print("oh hello i have a Collision") &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;print( "test " .. myName )&nbsp; &nbsp; &nbsp;if myName == "BCloud1" then &nbsp; &nbsp; &nbsp; &nbsp; print("Collided with star1") &nbsp; &nbsp;elseif event.other.myName == "BCloud2" then &nbsp; &nbsp; &nbsp; &nbsp; print("Collided with star2") &nbsp; &nbsp;elseif event.other.myName == "BCloud3" then &nbsp; &nbsp; &nbsp; &nbsp; print("Collided with star3") &nbsp; &nbsp;end end &nbsp;

bjsorrentino · May 14, 2013, 5:07pm

Hi Kevin,

When you do this:

[lua]

print( "test " … myName )

[/lua]

myName is undefined. You haven’t specified that it’s a property on the object, so Lua looks for it as a global variable and can’t find it. You need to specifiy it as a property of either “self” or “event.other”, just like you do in the lines below it.

mmk.verheijden · May 28, 2013, 12:22pm

oky so i’m trying this in a other way now :

local function onCollision(event) &nbsp;&nbsp;&nbsp;&nbsp;if event.phase == "began" and gameIsActive == true then &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local obj1 = event.object1;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local obj2 = event.object2;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;if obj1.name == "player" and obj2.name == "BCloud1" then &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;print("hello 1") &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; elseif obj1.name == "player" and obj2.name == "BCloud2" then &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;print("hello 2") &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; elseif obj1.name == "player" and obj2.name == "BCloud3" then &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;print("hello 3") &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; elseif obj1.name == "player" and obj2.name == "wall" then &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;print("hello im a wall") &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp;end end

Is this correct?

kevin-

bjsorrentino · May 28, 2013, 3:15pm

Hi Kevin,

This looks correct at first glance, but you’ll need to test it. Of course, I assume you’ve applied the “name” property to everything involved in collisions.

Brent

mmk.verheijden · May 28, 2013, 3:21pm

Hi Brent,

i am using randomStar.myName = “BCloud1” the privies errors are gone, but still it is not printing the print(“hello im a wall”)

in the terminal, i will have a play about whit it but its getting there ps dos corona handel the publication to the app/play store as well or only export the native app?

Kevin-

bjsorrentino · May 28, 2013, 3:24pm

Hi Kevin,

Remember to check that the either the player or the wall is a “dynamic” physics body type. At least one body in a collision needs to be dynamic… you can’t get collisions from a “static” + “kinematic” event, for example.

And FYI, Corona doesn’t handle the app submission (to market). It just builds the compiled file which you’ll need to submit to Apple, Google, etc. separately.

Take care,

Brent

mmk.verheijden · May 28, 2013, 3:30pm

physics.addBody(player, “dynamic”, {density=.1, bounce=0.1, friction=.2, radius=10,} )

right ?