Corona SDK support for Safari View Controller in iOS9

Solar2D iOS
#21

Thanks, Rob. I just looked at some code samples and it seems trivial to implement on your end. One writeup, for instance, says it’s less than ten lines of code and gives examples:

The Safari view controller is incredibly easy to use. In fact, it’s one of the smallest APIs I’ve seen with only two initializers and two delegate methods. Even so, it brings all of the features users expect from Safari over to your app.

Being able to use the Safari view controller and toggle readability mode is, from my perspective, the most important feature Corona could implement for iOS in the next year.

#22

It’s been three months since Safari view controller was announced and two months since this thread was started. 

Now that iOS 9 is out, it sure would be nice for Corona to support the controller – “incredibly easy to use” and “one of the smallest APIs I’ve seen” – in the very near future!

#23

Hi @corona273,

Has there been a feedback topic filed for this? If not, can you start one?

feedback.coronalabs.com

Thanks,

Brent

#24

Brent: Yes, it’s here:

http://feedback.coronalabs.com/forums/188732-corona-sdk-feature-requests-feedback/suggestions/9911013-adding-support-for-safari-view-controller-in-ios9

Though my sense is that the feedback forum is where good ideas go to languish. I can think of plenty of examples where Corona added features X, Y, and Z even though A, B, and C were top-ranked (though, to be sure, there are counterexamples as well).

Because this would be a trivial change on your part, as opposed to a major feature, perhaps you and your colleagues could find a few hours to implement it in the near future?

#25

Of the 246 ideas, we have completed 90, started 6 and declined 18.  We have addressed 46% of the items posted to the feedback site.

The feedback site is not the only source of deciding what we will add. Also the number of votes is not the deciding factor either. At the end of the day:

o Some things are very hard, some things are very easy.

o Some things benefit a large swath of the community, some things only benefit a few.

o Some things are best done by us in the core, some things are best done by the community or the 3rd party it benefits.

We analyze all of this before we decide what to commit engineering resources to.

Rob

#26

The current WebView in iOS has many restrictions which the Android WebView does not have. For this reason, for example, I cannot call up a video from the WebView browser, significantly impacting my App.

From analyzing above, it appears that implementing the new Safari WebView should require very little effort. I WILL ADD THE FEEDBACK that Corona requires to prioritize work. However, unless this is advertised properly to the community here online, I’m concerned that it will languish in priority. So PLEASE, do this soon!?

#27

Rob: I think you’ve spent more time explaining The Process and The Procedure and The Priorities than it would take an engineer to implement those < 10 lines of code. If it were a major undertaking, sure, we understand. But < 10 lines of code? :slight_smile:

I know it’s not your decision, but remember we’re all developers here! 

Maybe we need to crowdfund this? I will pledge $100 in Bi-Rite Creamery ice cream (San Francisco’s finest) and other tasty treats to be delivered to Corona’s Palo Alto offices if this is implemented by the end of next week. Not joking, BTW. <troylyndon>, are you in?

#28

Just to be clear, 10 lines of code is never 10 lines of code. Do we give you a new native.newSafariView()? Do we replace the code in native.newWebView()? What about for people who are not on iOS 9? Are events going to be call compatible?

Sure for a native iOS app if you want to add a UISafariViewController, it may be 10 lines, but when you’re trying to build a framework for everyone that’s cross platform then things are different. It’s not going to be 10 lines for us. We have to support more than a basic installation.

And finally, when Apple brings out a new OS, it’s in our best interest to wait until the OS stabilizes before we start trying to integrate it. First we work on new OS things that will break us (which is why we have to let Apple get their bugs out first) and prevent you from being able to build, then we go back and look at adding new features.

#29

Rob: I understand from one of your colleagues that Corona has made some nice progress on this, so thank you.

#30

Rob: Hey! I think this may be the first time Corona has ever been able to take me up on one of my Bi-Rite Creamery offers.

I posted on 9/25 that: “I will pledge $100 in Bi-Rite Creamery ice cream (San Francisco’s finest) and other tasty treats to be delivered to Corona’s Palo Alto offices if this is implemented by the end of next week. Not joking, BTW.”

Your colleague emailed me details on Friday 10/2, which seems to have satisfied my deadline.

Wow. It looks like I owe you folks some tasty snacks.

#31

https://store.coronalabs.com/plugin/safari-view

https://docs.coronalabs.com/daily/plugin/CoronaProvider_native_popup_safariView/index.html

#32

Rob, I’m in for $50 more of goodies for the Corona team. Just let me know the vendor, what you/they’d like, and I’ll order it up! We really are grateful for this new plug-in.

#33

Troy: Too late! I placed the Amazingly Tasty SF Treat order last night and it will be arriving in the 11am-3pm window today.

Unfortunately there is a problem with Corona’s implementation of Safari View Controller affecting all apps that support rotation, which I posted about here: https://forums.coronalabs.com/topic/59577-safari-view/

 

Maybe you can send the next $50 of goodies once this is fixed. Keeps incentives aligned and all that. :slight_smile:

#34

Treats arrived – thank you corona273!

#35

Quite welcome! Glad they arrived safely (and without too much melting, I hope!).

I recall Rob works remotely so wasn’t able to join you but I did thank him on the card accompanying the delivery – mostly for putting up with my requests here for the last few years! (I wasn’t sure who was responsible for the Safari View Controller – maybe you? – so I wasn’t able to thank him or her directly.)