8 year old bug fixed in transition framework!

I know that everyone loves transition library, including me. So i was surfing through the source codes to implement custom transition changes (i will write about them soon) that i eventually needed in my project and had found a funny typo in transition.blink function:


As you can see not existing easing.continousLoop is used instead of easing.continuousLoop.

This is cause blinked object to fade out smooth and then instant fade in since easing.linear is used for transition except easing.continousLoop which is equals to nil.

The bug appeared on September 11, 2013 with the release of version 2.0 of transition framework, when the function itself was added (initially with this error).

I cannot find any topics related to this behaviour on forum neither issue on Github or Discord. Maybe because of this behaviour falls under the definition of “blinking” and doesn`t arise any questions.

Anyway, i doubt this is desired behaviour that developers wanted to implement.

To fix this typo and not affect any of millions existing projects I added a new function transition.blinkContinuous with correct continuousLoop.

Here you can see the difference:
blink_diff

I hope you will enjoy a wide variety of blinkings available by this framework if it will be merged into source transition ofc.:slight_smile:, or you can test it out right now by visiting my fork: https://github.com/MisterProper9000/framework-transition/tree/hotfix-blink

Link to pull request https://github.com/coronalabs/framework-transition/pull/5

12 Likes