daily build 1260 broke scrollview listeners

Stephen_Lewis · November 14, 2013, 8:36pm

The following code will print “began scrolling” in the console if the user drags the scrollview in daily 1257, but in daily 1260 the listener never gets called.

&nbsp;&nbsp;&nbsp;&nbsp;local widget = require( "widget" ) &nbsp;-- for the scrollview &nbsp;&nbsp;&nbsp;&nbsp;local function scrollListener( event ) &nbsp;&nbsp;&nbsp;&nbsp; &nbsp; &nbsp;local phase = event.phase &nbsp;&nbsp;&nbsp;&nbsp; &nbsp; &nbsp;if "began" == phase then &nbsp;&nbsp;&nbsp;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;print("began scrolling") &nbsp;&nbsp;&nbsp;&nbsp; &nbsp; &nbsp;end &nbsp;&nbsp;&nbsp;&nbsp; &nbsp; &nbsp;return true &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp; &nbsp; &nbsp; &nbsp; -- Create a ScrollView &nbsp; &nbsp; local scrollView = widget.newScrollView &nbsp; &nbsp; &nbsp; &nbsp; { &nbsp; &nbsp; &nbsp; &nbsp; top = 75, &nbsp; &nbsp; &nbsp; &nbsp; left = 20, &nbsp; &nbsp; &nbsp; &nbsp; width = 280, &nbsp; &nbsp; &nbsp; &nbsp; height = 300, &nbsp; &nbsp; &nbsp; &nbsp; topPadding = 75,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bottomPadding = 50,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; listener = scrollListener, &nbsp; &nbsp; &nbsp; &nbsp; hideScrollBar = true, &nbsp; &nbsp; &nbsp; &nbsp; horizontalScrollDisabled = true, &nbsp; &nbsp; &nbsp; &nbsp; hideBackground = true, &nbsp; &nbsp; &nbsp; &nbsp; } &nbsp;

Stephen_Lewis · November 14, 2013, 8:44pm

Correction, the listener is getting called. If I add

print("made it to listener") &nbsp;

to the first line of the listener function I do see that printed in the console. But the “began” phase check is never encountered with daily build 1260 but it is in 1257.

ksan · November 14, 2013, 10:18pm

its not only a problem with “began”. I put a print (phase) call in my listener and I’m getting nil printed in place of began, moved and ended phases. So it seems like none of these guys are making it through… Back to Alex!

edit - on a positive note, direction works though!

Stephen_Lewis · November 18, 2013, 8:23pm

I’m in the process of “upgrading” my in-progress app to G2.0/2076 and this is still an issue. I filed a bug report, Case 28111.

corona273 · November 19, 2013, 9:14pm

Thanks for flagging this. There are at least two other threads in different areas of the forum (widgets and advanced graphics) noting that event.phase is returning nil:

http://forums.coronalabs.com/topic/41489-scrollview-eventphase-returns-nil/

http://forums.coronalabs.com/topic/41531-eventphase-not-detected-in-scrolllistener-of-scrollview/

I filed it as a bug yesterday afternoon (Case 28117) but have not received a response from Corona yet.

corona273 · November 19, 2013, 10:04pm

FYI, Brett from Corona replied in another thread and said it would be fixed “soon” in a daily build:

http://forums.coronalabs.com/topic/41489-scrollview-eventphase-returns-nil/

joe528 · November 20, 2013, 1:09pm

I thought I broke something with my code by my today’s change

although it only took me 10 mins to find out it’s because of the latest build that breaks scrollView

Corona should pay the medicine fee for my heart attack

corona273 · November 20, 2013, 10:18pm

So daily build 2013.2082 came out today, and there’s no mention of the scrollview bug being fixed:

http://developer.coronalabs.com/release/2013/2082/

bjsorrentino · November 20, 2013, 11:16pm

Hi guys,

Let’s try to keep this in one thread… there are like 3 threads out there reporting this, so we’re well aware of it.

This should be fixed in the next build, after #2082.

Brent

corona273 · November 21, 2013, 3:37am

Yay!

Daily build 2013.2085: “Widget 2.0: Fixes the scrollView event.phase not being passed to the listener” http://developer.coronalabs.com/release/2013/2085/

Thanks, Brent!

Stephen_Lewis · November 21, 2013, 3:58am

2085 fixed my scrollView event issues. Thanks, Brent!

ksan · November 21, 2013, 5:46am

Something is still a little wonky. If you uncomment those event phase print statements so you get to see began, moved and ended and then try the following on WidgetDemo tab 1…

Click and hold on a row.
Move up and down without releasing … you will see moved printed in console which is normal.
Then while still holding on the same row move your cursor left to right… you will still see moved printed in console but actually tabView is not moving. Its actually a slideleft event followed by slideright event etc…
Then release the click and you will see one more moved event and then a nil printed to console…
If you follow the above you also don’t get the next window fire up that says you pressed on Row x etc with the back button.

Not sure whats wrong there but something slightly off. Good to see widgets getting good attention. Thank you very much!

bjsorrentino · November 21, 2013, 9:57am

Hi Kerem,

Have you proven that you didn’t slide the row/view slightly up (or down) while holding it and sliding right (or left)? Even one or two pixels? Can you confirm that this didn’t happen previously in earlier builds?

Can anybody else replicate what Kerem reports here?

Brent

ksan · November 21, 2013, 5:36pm

Hi Brent,

I had not noticed this before so I went back and downloaded #1235 just to check. The same behavior is there too. I think slide left / right is still firing so the fact that moved is also firing there is perhaps not so much of an issue. The bigger issue is that if you press & hold on a row and move up and down and then release the normal OnTap Release is not happening. Not a huge issue but one that can use some attention at some point. Thanks for your help.

Regards,

Kerem

alan_slane · November 28, 2013, 10:57pm

For anyone who doesn’t have a subscription to get the daily build with the fix, I hacked out a quick fix in the meantime:

local isBegan = true local scrollTimer &nbsp;&nbsp;&nbsp;&nbsp; -- ScrollView listener local function scrollListener( event ) &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp; if(scrollTimer~=nil)then &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;timer.cancel(scrollTimer) &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp; &nbsp; if(isBegan==true)then &nbsp; &nbsp; &nbsp; &nbsp; print("Phase Began") &nbsp; &nbsp; &nbsp; &nbsp; isBegan = false else print("Phase Moved") &nbsp; &nbsp; end &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;local function phaseEnded() &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;print("Phase Ended") &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;isBegan = true &nbsp;&nbsp;&nbsp;&nbsp;end scrollTimer=timer.performWithDelay(150,phaseEnded,1) end &nbsp;

If it’s a slow swipe, the began phase might be called multiple times…if this is happening, increase the timer from 150 to 200 or 300. Tweak around a bit, and you should get it good enough for the moment!

Stephen_Lewis · November 14, 2013, 8:44pm

Correction, the listener is getting called. If I add

print("made it to listener") &nbsp;

to the first line of the listener function I do see that printed in the console. But the “began” phase check is never encountered with daily build 1260 but it is in 1257.

ksan · November 14, 2013, 10:18pm

its not only a problem with “began”. I put a print (phase) call in my listener and I’m getting nil printed in place of began, moved and ended phases. So it seems like none of these guys are making it through… Back to Alex!

edit - on a positive note, direction works though!

Stephen_Lewis · November 18, 2013, 8:23pm

I’m in the process of “upgrading” my in-progress app to G2.0/2076 and this is still an issue. I filed a bug report, Case 28111.

corona273 · November 19, 2013, 9:14pm

Thanks for flagging this. There are at least two other threads in different areas of the forum (widgets and advanced graphics) noting that event.phase is returning nil:

http://forums.coronalabs.com/topic/41489-scrollview-eventphase-returns-nil/

http://forums.coronalabs.com/topic/41531-eventphase-not-detected-in-scrolllistener-of-scrollview/

I filed it as a bug yesterday afternoon (Case 28117) but have not received a response from Corona yet.

corona273 · November 19, 2013, 10:04pm

FYI, Brett from Corona replied in another thread and said it would be fixed “soon” in a daily build:

http://forums.coronalabs.com/topic/41489-scrollview-eventphase-returns-nil/