Pretty basic MapView crashes on Android, glitches a little on Iphone

henrik5 · January 16, 2014, 2:19pm

I’m using graphics v1 compatibility mode and the scene is shown as an overlay.

Can you spot an error in my code? I have checked it against the example in docs. The only difference is that it has the newMapView outside createScene. I must, because it has a nav bar.

local storyboard=require("storyboard") local scene=storyboard.newScene() GEOADDR="Storgatan 1, Nassjo, Sweden" local tfaddr local myMap local function onbback(e) &nbsp;&nbsp;&nbsp;&nbsp;native.setKeyboardFocus( nil ) &nbsp;&nbsp;&nbsp;&nbsp;storyboard.hideOverlay("slideRight",400) &nbsp;&nbsp;&nbsp;&nbsp;return true end&nbsp; local function fieldHandler( getObj ) &nbsp; &nbsp; return function( event )&nbsp;&nbsp;&nbsp;&nbsp;-- Use Lua closure in order to access the TextField object &nbsp; &nbsp; &nbsp; &nbsp; print( "TextField Object is: " .. tostring( getObj() ) ) &nbsp; &nbsp; &nbsp; &nbsp; if ( "began" == event.phase ) then&nbsp;&nbsp;&nbsp;&nbsp;--onfocus &nbsp; &nbsp; &nbsp; &nbsp; elseif ( "ended" == event.phase ) then&nbsp;&nbsp;&nbsp;&nbsp;--onblur &nbsp; &nbsp; &nbsp; &nbsp; elseif ( "submitted" == event.phase ) then&nbsp;&nbsp;&nbsp;&nbsp;--onenter &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; native.setKeyboardFocus( nil ) &nbsp; &nbsp; &nbsp; &nbsp; end &nbsp; &nbsp; end &nbsp; &nbsp; -- "return function()" end local function onbaddr(e) &nbsp;&nbsp;&nbsp;&nbsp;GEOADDR=tostring( tfaddr.text) &nbsp; &nbsp; if GEOADDR:len()\>0 then &nbsp; &nbsp; &nbsp;&nbsp;&nbsp;&nbsp;print( "Text entered = " .. GEOADDR ) &nbsp; &nbsp; &nbsp; &nbsp; -- display the text entered &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;myMap:requestLocation( GEOADDR, mapLocationHandler ) &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;native.setKeyboardFocus( nil ) &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp;return true&nbsp;&nbsp;&nbsp;&nbsp; end&nbsp; local function onbpinme(e) &nbsp;&nbsp;&nbsp;&nbsp;pinlat=91&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;--flag &nbsp;--pinlon=USERLON &nbsp;&nbsp;&nbsp;&nbsp;--'move' pin and zoom to it &nbsp;&nbsp;&nbsp;&nbsp;myMap:removeAllMarkers() &nbsp;&nbsp;&nbsp;&nbsp;local options={title="Selected location:",subtitle="Your phone's location"} &nbsp;&nbsp;&nbsp;&nbsp;myMap:addMarker(USERLAT,USERLON,options) &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;myMap:setCenter(USERLAT,USERLON,true) &nbsp;&nbsp;&nbsp;&nbsp;myMap:nearestAddress(pinlat,pinlon,mapAddressHandler) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;return true&nbsp;&nbsp;&nbsp;&nbsp; end&nbsp; local function tfaddrHandler( event ) &nbsp;&nbsp;&nbsp;&nbsp;fieldHandler( function() return tfaddr end ) -- passes the text field object end ----------------------- local function mapLocationHandler( event ) &nbsp; &nbsp; if event.isError then &nbsp; &nbsp; &nbsp; &nbsp; local alert=native.showAlert("Google can't find "..GEOADDR,event.errorMessage,{"OK"}) &nbsp; &nbsp; else &nbsp; &nbsp; &nbsp; &nbsp; --'move' pin and zoom to it &nbsp; &nbsp; &nbsp; &nbsp; pinlat=event.latitude &nbsp; &nbsp; &nbsp; &nbsp; pinlon=event.longitude &nbsp; &nbsp; &nbsp; &nbsp; myMap:removeAllMarkers() &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local options={title="Selected location:",subtitle=GEOADDR} &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;myMap:addMarker(pinlat,pinlon,options) &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;myMap:setCenter(pinlat,pinlon,true) &nbsp; &nbsp; end end local function mapAddressHandler(e) &nbsp; &nbsp; if e.isError then &nbsp; &nbsp; &nbsp; &nbsp; tfaddr.text="Address not found" &nbsp; &nbsp; else &nbsp; &nbsp; &nbsp; &nbsp; tfaddr.text=e.city..", "..e.country &nbsp; &nbsp; end end local function getAddr() &nbsp;&nbsp;&nbsp;&nbsp;myMap:nearestAddress(pinlat,pinlon,mapAddressHandler) end local function callMap() &nbsp;&nbsp;&nbsp;&nbsp;local currloc=myMap:getUserLocation() &nbsp;&nbsp;&nbsp;&nbsp;if currloc then &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local currlat=currloc.latitude &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;local currlon=currloc.longitude &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;myMap:setCenter(currlat,currlon,true)&nbsp;&nbsp;&nbsp;&nbsp;--,1.5,1.5,true) &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;myMap:nearestAddress(currentLatitude,currentLongitude) &nbsp;&nbsp;&nbsp;&nbsp;end end&nbsp; -- Called when the scene's view does not exist: function scene:createScene(event) &nbsp;&nbsp;&nbsp;&nbsp;print("map createScene") &nbsp;&nbsp;&nbsp;&nbsp;bg=display.newImageRect("assets/black16x16.png",CW2,CH2-50-T)&nbsp;&nbsp;&nbsp;&nbsp;--white bg &nbsp;&nbsp;&nbsp;&nbsp;bg.x=CW &nbsp;&nbsp;&nbsp;&nbsp;bg.y=T+(CH2-50-T)/2 &nbsp;&nbsp;&nbsp;&nbsp;self.view:insert(bg) &nbsp;&nbsp;&nbsp;&nbsp;--navbar &nbsp;&nbsp;&nbsp;&nbsp;inavbar=display.newImageRect("assets/navbarbg.png",320,64) &nbsp;&nbsp;&nbsp;&nbsp;inavbar.x=CW &nbsp;&nbsp;&nbsp;&nbsp;inavbar.y=64/2&nbsp;&nbsp;&nbsp;&nbsp;--incl shadow&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;self.view:insert(inavbar) &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;bback=backbuttonarrow("Tillbaka","bback",onbback,14) &nbsp;&nbsp;&nbsp;&nbsp;self.view:insert(bback) &nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;tfaddr=native.newTextField( CW-106, 6, 172, 32 ) &nbsp;&nbsp;&nbsp;&nbsp;tfaddr:addEventListener( "userInput", tfaddrHandler ) &nbsp;&nbsp;&nbsp;&nbsp;tfaddr.isVisible=false &nbsp;&nbsp;&nbsp;&nbsp;baddr=imgbuttonr("search","baddr",CW2-40-4-44-6,0,44,44,onbaddr) &nbsp;&nbsp;&nbsp;&nbsp;self.view:insert(baddr)&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;bpinme=imgbuttonr("gps","bpinme",CW2-40-4-0,0,44,44,onbpinme) &nbsp;&nbsp;&nbsp;&nbsp;self.view:insert(bpinme)&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;--map-- &nbsp;&nbsp;&nbsp;&nbsp;myMap=native.newMapView(0,0,CW2,CH2-T-50) &nbsp;&nbsp;&nbsp;&nbsp;myMap.mapType="hybrid" -- other mapType options are "satellite" or "hybrid" &nbsp;&nbsp;&nbsp;&nbsp;-- The MapView is just another Corona display object,and can be moved or rotated,etc. &nbsp;&nbsp;&nbsp;&nbsp;myMap.x=CW &nbsp;&nbsp;&nbsp;&nbsp;myMap.y=(CH2-50-T)/2+T &nbsp;&nbsp;&nbsp;&nbsp;self.view:insert(myMap) &nbsp;&nbsp;&nbsp;&nbsp;--Runtime:addEventListener("mapAddress",mapAddressHandler) end -- Called immediately after scene has moved onscreen: function scene:enterScene(event) &nbsp;&nbsp;&nbsp;&nbsp;print("enterScene view"..tabindex)&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;if pinlat\>90 then &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;pinlat=mylat &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;pinlon=mylon &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp;local options={title="Selected location:",subtitle="Your phone's location"} &nbsp;&nbsp;&nbsp;&nbsp;myMap:addMarker(pinlat,pinlon,options) &nbsp;&nbsp;&nbsp;&nbsp;tfaddr.isVisible=true &nbsp;&nbsp;&nbsp;&nbsp;--myMap:setCenter(pinlat,pinlon,true) &nbsp;&nbsp;&nbsp;&nbsp;timer.performWithDelay(1000,callMap) -- get current location after 1 second &nbsp;&nbsp;&nbsp;&nbsp;--timer.performWithDelay(2500,getAddr) end&nbsp; -- Called when scene is about to move offscreen: function scene:exitScene(event) &nbsp;&nbsp;&nbsp;&nbsp;print("exitScene view"..tabindex)&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;-- INSERT code here (e.g. stop timers,remove listeners,unload sounds,etc.) &nbsp;&nbsp;&nbsp;&nbsp;myMap:removeAllMarkers() end -- If scene's view is removed,scene:destroyScene() will be called just prior to: function scene:destroyScene(event) &nbsp;&nbsp;&nbsp;&nbsp;-- INSERT code here (e.g. remove listeners,remove widgets,save state variables,etc.) &nbsp;&nbsp;&nbsp;&nbsp;if myMap then&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;--Runtime:removeEventListener("mapAddress",mapAddressHandler) &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;myMap:removeSelf() &nbsp;&nbsp;&nbsp;&nbsp;end &nbsp;&nbsp;&nbsp;&nbsp;if tfaddr then &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;tfaddr.isVisible=false &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;tfaddr:removeEventListener("userInput",tfaddrHandler) &nbsp;&nbsp;&nbsp;&nbsp;end&nbsp;&nbsp;&nbsp;&nbsp; end scene:addEventListener("createScene",scene)&nbsp;&nbsp;&nbsp;&nbsp;-- "createScene" event is dispatched if scene's view does not exist scene:addEventListener("enterScene",scene)&nbsp;&nbsp;&nbsp;&nbsp;-- "enterScene" event is dispatched whenever scene transition has finished scene:addEventListener("exitScene",scene)&nbsp;&nbsp;&nbsp;&nbsp;-- "exitScene" event is dispatched whenever before next scene's transition begins scene:addEventListener("destroyScene",scene)&nbsp;&nbsp;&nbsp;&nbsp;-- "destroyScene" event is dispatched before view is unloaded,which can be -- automatically unloaded in low memory situations,or explicitly via a call to -- storyboard.purgeScene() or storyboard.removeScene(). return scene &nbsp;

Let me know any hints to get this working rock solid. Using Corona 2076.

henrik5 · January 17, 2014, 9:42am

Managed to film the crash messages and pause the frame. The lesson learned was that handlers must be at the top of the source, so that functions that use them don’t get a nil for the handler argument. In general you should define functions in load->use order.

You can store it in a variable to avoid this, and I suspect if they hadn’t been local functions it would also have worked.

It crashed with and without v1 compatbility mode and now works in both, so that rules out any problems with build 2076.

henrik5 · January 17, 2014, 1:25pm

There seems to be a problem with re-adding markers with 2076, though. The first time a marker is added, it works properly. The following times a marker is added, that marker’s coordinate system vs. the map scale is out of wack - as I zoom out, the marker is moved to another part of the country or outside the view…

local function onbpinme(event) &nbsp;&nbsp;&nbsp;&nbsp;myMap:setCenter(USERLAT,USERLON,true) &nbsp;&nbsp;&nbsp;&nbsp;myMap:nearestAddress(USERLAT,USERLON,mapAddressHandler) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp;&nbsp;&nbsp;myMap:removeAllMarkers() &nbsp;&nbsp;&nbsp;&nbsp;local options={title="Selected location:",subtitle="Your phone's location"} &nbsp;&nbsp;&nbsp;&nbsp;myMap:addMarker(USERLAT,USERLON,options) &nbsp;&nbsp;&nbsp;&nbsp;return true&nbsp;&nbsp;&nbsp;&nbsp; end &nbsp;

I will be very happy if you can locate any error in my code, or a workaround, such as “moving” a marker instead of deleting and re-adding it.

This happens with or without v1 compatibility mode. Help!!

henrik5 · January 17, 2014, 1:51pm

Saving the marker ID and removing just that if it’s set, doesn’t fix it. (I’m not editing my previous post since editing posts breaks the code formatting.)

Edit: I’ve now put the map creation code at the top of the source outside any function, instead of in createScene, and I don’t self.view:insert() it anymore. I also don’t removeSelf() on exit. Still doesn’t work for the subsequent removeMarker()+addMarker().

If I don’t use removeAllMarkers() or removeMarker() at all, it works. But I’d need some way of hiding them then, or access some table that I can empty manually with some magic code.

Edit 2: Also tried using gotoScene() rather than showOverlay() for the map scene, but of course having moved newMapView outside createScene() means I have no way of removing the mapView, so it stay on-screen when the main view slides in.

There’s just no way I can seem to solve this and make a functioning app, because removing markers places the new ones in some unrelated co-ordinate system.

rob · January 18, 2014, 3:37am

I would recommend updating Corona SDK to the latest public build 2100. and give that a go. If you are still having problems you will need to examine your console logs on your device and see if any errors are being generated.

Rob

henrik5 · January 20, 2014, 8:22am

Yes, docs made me think I was using the latest SDK. 2013.2100 fixed this map pin error as well, so my app is hunky dory at the moment. This thread could be deleted to not confuse a visitor who has a genuine problem with the map view. Edit: nope, I judged too quickly.

rob · January 21, 2014, 12:00am

When you start Corona SDK, it should provide you the build number on the welcome screen as well as Under the About menu item.

Rob

henrik5 · January 21, 2014, 11:04am

Yes, I was a bit too quick about it and compared that to the online docs, which say the current version is 2013.2076.

Looking at the logs I suspect some nil checks are to blame. How would I check a returned timer handle, whether it has been set or not, and how do I check a returned marker id whether a marker has been placed or not?

henrik5 · January 21, 2014, 12:48pm

No, my code checks out. The marker bug is still there in 2013.2100, and it’s a bug. I just discovered that when this marker position goes off, the hitbox for the touch event is still in the correct place and triggers a callout correctly which “points” to the co-ordinates supplied it. I’ve filed the bug.

nmichaud · February 4, 2014, 8:11pm

@henrik 5, do you have the bug number ? This bug is also killing us. RemovingAllMarker and adding new one is bogus and even on the latest build .2156

nmichaud · February 4, 2014, 9:02pm

After looking on FogBugz we did not see any bugs relate to our problem. We have open a bug as the removeAllMarker and addMarker is currently unreliable.

Bladko · February 6, 2014, 10:05pm

Btw what is limit to add markers to map ?

I load marker data from my server on load (just json data), then create it

local idd = myMap:addMarker( x, y, options )

After approximately 100 or 150 markers my iOS devices crushes

I run publish starter version 2100

ksan · February 6, 2014, 10:07pm

Oops. I was just about to start a project where I will need to put in 100+ markers. I hope there is no such limitation at all.

nmichaud · February 6, 2014, 10:12pm

@Bladko, so far we did not see any limit on the number of marker you can add. One of our thematic in our tourism app currently display 205 markers on iOS devices without any trouble.

On Android it is another story, we are working with the dev team to narrow down some unpredictable result when you addmarker after operations like removeAllMarker/SetRegion/SetCenter.

henrik5 · January 17, 2014, 9:42am