Remove spawnobjects function on exitScene()?

JamesMallon · February 25, 2014, 1:45pm

So the function below spawns dustbins. in

function spawnDustbin() i = 0 dustbin = {} &nbsp;&nbsp;&nbsp;&nbsp;i = i + 1 &nbsp;&nbsp;&nbsp;&nbsp;dustbin[i] = display.newImage("dustbin.png") &nbsp;&nbsp;&nbsp;&nbsp;dustbin[i].xScale = 0.55 &nbsp;&nbsp;&nbsp;&nbsp;dustbin[i].yScale = 0.55 &nbsp;&nbsp;&nbsp;&nbsp;dustbin[i].y = 555 &nbsp;&nbsp;&nbsp;&nbsp;dustbin[i].x = (math.random(1000,1100) \* i) &nbsp;&nbsp;&nbsp;&nbsp;dustbin[i].speed = 4 &nbsp;&nbsp;&nbsp;&nbsp;physics.addBody( dustbin[i], "static", { friction=1.0, density=1.0, bounce=0, radius=60} ) &nbsp;&nbsp;&nbsp;&nbsp;dustbin[i].enterFrame = moveDustbin &nbsp;&nbsp;&nbsp;&nbsp;Runtime:addEventListener("enterFrame", dustbin[i]) end &nbsp;

in enter scene the line:

timer.performWithDelay(1000, spawnDustbin, 14)

Calls the function but how do I remove the dustbins off the scene on exitscene all help welcome!

Thank you

James

nick_sherman · February 25, 2014, 2:48pm

If you add them to your scene view (by default this is called group in storyboard) then you don’t need to remove them manually.

[lua]

group:insert(dustbin[i])

[/lua]

Alex10 · February 25, 2014, 2:53pm

James, I gave you this:

local dustbin = {} local i = 0 local function spawnDustbin() i = i+1 dustbin[i] = display.newImage("dustbin.png") dustbin[i].xScale = 0.55 dustbin[i].yScale = 0.55 dustbin[i].y = 555 dustbin[i].x = (math.random(1000,1500) \* i) dustbin[i].speed = 4 physics.addBody( dustbin[i], "static", { friction=1.0, density=1.0, bounce=0, radius=30,} ) dustbin[i].enterFrame = moveDustbin Runtime:addEventListener("enterFrame", dustbin[i]) end timer.performWithDelay(500, spawnDustbin, 10)

and you changed it to this:

function spawnDustbin() i = 0 dustbin = {} i = i + 1 dustbin[i] = display.newImage("dustbin.png") dustbin[i].xScale = 0.55 dustbin[i].yScale = 0.55 dustbin[i].y = 555 dustbin[i].x = (math.random(1000,1100) \* i) dustbin[i].speed = 4 physics.addBody( dustbin[i], "static", { friction=1.0, density=1.0, bounce=0, radius=60} ) dustbin[i].enterFrame = moveDustbin Runtime:addEventListener("enterFrame", dustbin[i]) end

Why did you change the code there? I’m not saying you’re wrong, but you’re going to run into problems when you attempt to remove your dustbins.

JamesMallon · February 25, 2014, 2:55pm

Hey no the line of code that nick provided above worked perfectly I now have no issues with the removal of dustbins!

Thank You for your help though that saved me.

James

JamesMallon · February 25, 2014, 3:04pm

Sorry you were right! when i finish the scene then go back to the scene when i click my restart button it just shows me dustbins no skater somethings wrong here…

Alex10 · February 25, 2014, 3:09pm

So why did you change the code I provided? Can you describe exactly what you’re attempting to accomplish and include any pertinent code snippets so that we can identify the issue and provide assistance?

JamesMallon · February 25, 2014, 3:32pm

Okay so this is it:

My skateboarder is going to jump over a trash can, he does that perfectly with no issue and can jump over the other trash cans without issue.

On collision with a trash can the skateboarder is going to crumble into pieces which will fall to the floor. At the moment Im working on that so on collison the app goes to the intro scene and then to the menu and then when i click play as soon as my skateboarder jumps the screen goes to the intro again!

I have sent you the code via private message, here are the screenshots:

everything is perfect trash cans move normally etc

The skater is stuck the background isnt scrolling the trash cans arent moving etc.

Thankyou so much

James

Alex10 · February 25, 2014, 5:19pm

While we’re waiting for you to post your code, I can guarantee you aren’t removing your listeners when you leave your scene. Try using print statements in your gameloop/Runtime listeners to check to see if they are stopped when you leave the scene.

Recommended reading:

- http://coronalabs.com/blog/2013/08/20/tutorial-reloading-storyboard-scenes/

- http://coronalabs.com/blog/2013/05/28/tutorial-goodbye-globals/

JamesMallon · February 25, 2014, 6:53pm

I sent you my code via private message but ill have a look at this and try by myself atm

Thanks!

James

Alex10 · February 25, 2014, 7:10pm

Assisting via private message isn’t really the intent of the forums. Rest assured, there are enough Flappy Bird clones and free templates that exist that no one will beat you to the punch. In order to support the community and make sure that I provide information from which everyone can benefit, posting your code in this thread is the only way I can provide assistance.

JamesMallon · February 25, 2014, 7:11pm

I suppose you’re right!

Okay so this is my game code:

–

Alex10 · February 25, 2014, 7:30pm

Looking at your code, I see a lot of globals. It is of vital importance that you read through the “goodbye globals” tutorial so that you can structure your code in such a way that doesn’t breed memory leaks, and makes it easier to reload your scene. Check out the Storyboard Sample Project to see how best to declare local variables and so on.

Have you tried adding print statements to your Runtime listeners to make sure that they are in fact being removed when you leave the scene? This will print info to the terminal and tell you whether or not all of your listeners are being removed.

JamesMallon · February 25, 2014, 7:52pm

Ill do that now and see if it works!

nick_sherman · February 25, 2014, 2:48pm

If you add them to your scene view (by default this is called group in storyboard) then you don’t need to remove them manually.

[lua]

group:insert(dustbin[i])

[/lua]

Alex10 · February 25, 2014, 2:53pm

James, I gave you this:

local dustbin = {} local i = 0 local function spawnDustbin() i = i+1 dustbin[i] = display.newImage("dustbin.png") dustbin[i].xScale = 0.55 dustbin[i].yScale = 0.55 dustbin[i].y = 555 dustbin[i].x = (math.random(1000,1500) \* i) dustbin[i].speed = 4 physics.addBody( dustbin[i], "static", { friction=1.0, density=1.0, bounce=0, radius=30,} ) dustbin[i].enterFrame = moveDustbin Runtime:addEventListener("enterFrame", dustbin[i]) end timer.performWithDelay(500, spawnDustbin, 10)

and you changed it to this:

function spawnDustbin() i = 0 dustbin = {} i = i + 1 dustbin[i] = display.newImage("dustbin.png") dustbin[i].xScale = 0.55 dustbin[i].yScale = 0.55 dustbin[i].y = 555 dustbin[i].x = (math.random(1000,1100) \* i) dustbin[i].speed = 4 physics.addBody( dustbin[i], "static", { friction=1.0, density=1.0, bounce=0, radius=60} ) dustbin[i].enterFrame = moveDustbin Runtime:addEventListener("enterFrame", dustbin[i]) end

Why did you change the code there? I’m not saying you’re wrong, but you’re going to run into problems when you attempt to remove your dustbins.

JamesMallon · February 25, 2014, 2:55pm

Hey no the line of code that nick provided above worked perfectly I now have no issues with the removal of dustbins!

Thank You for your help though that saved me.

James

JamesMallon · February 25, 2014, 3:04pm

Sorry you were right! when i finish the scene then go back to the scene when i click my restart button it just shows me dustbins no skater somethings wrong here…

Alex10 · February 25, 2014, 3:09pm

So why did you change the code I provided? Can you describe exactly what you’re attempting to accomplish and include any pertinent code snippets so that we can identify the issue and provide assistance?

JamesMallon · February 25, 2014, 3:32pm

Okay so this is it:

My skateboarder is going to jump over a trash can, he does that perfectly with no issue and can jump over the other trash cans without issue.

On collision with a trash can the skateboarder is going to crumble into pieces which will fall to the floor. At the moment Im working on that so on collison the app goes to the intro scene and then to the menu and then when i click play as soon as my skateboarder jumps the screen goes to the intro again!

I have sent you the code via private message, here are the screenshots:

everything is perfect trash cans move normally etc

The skater is stuck the background isnt scrolling the trash cans arent moving etc.

Thankyou so much

James

Alex10 · February 25, 2014, 5:19pm

While we’re waiting for you to post your code, I can guarantee you aren’t removing your listeners when you leave your scene. Try using print statements in your gameloop/Runtime listeners to check to see if they are stopped when you leave the scene.