Showstopper (crash) with Onesignal plugin and GPS on Android 6.x

josh_OneSignal · June 29, 2016, 10:40pm

I am able to reproduce the crash however I was not able find a work around. The crash is definitely happening in Corona’s PermissionsSettings class. The app only crashes when you build with OneSignal as it adds extra permissions that is triggering a bug in Corona’s code.

Can you try an older build of Corona?

@Rob Miracle

Could you have some one look at PermissionsSettings.java with the exception noted above in the Corona source? It seems the string[] array being passed to it isn’t formatted correctly.

rob · June 30, 2016, 4:16pm

I’ll need a bug report filed please. It will need a small app that demonstrates the problem. Zip up the main.lua, config.lua and build.settings used and any assets, and use the “Report a bug” link at the top of the page.

You will get an email with the CaseID in it. Post it back here and I’ll see if I can get someone to look at it.

Rob

nmichaud · June 30, 2016, 4:52pm

A bug have been submitted with the same sampleApp I put initially in this thread to reproduce the bug. The case ID 46616

rob · June 30, 2016, 5:00pm

You should have gotten an email confirming the bug submission. The CaseID is in the subject of that message.

It looks like its case 46616.

Rob

nmichaud · June 30, 2016, 7:03pm

Hi receive this from this answer from the ticket I have opened. Frankly, I do not know what to do as OneSignal already did an investigation pointing to Corona and Corona says talk to the plugin owner!

Hello, Unfortunately OneSignal is a third parity plugin so you will need to contact the developer and have them resolve the issue. We don't have access to their code so we can't debug the issue. Regard,

rob · June 30, 2016, 7:30pm

Let me see what I can find out…

rob · July 1, 2016, 6:04pm

They re-looked at the issue and if I followed things correctly, we’ve made a change to address an edge case. The changes should be in the next daily build at which I’m assuming Josh will need to update the plugin. I don’t know when we will resume daily builds. We usually wait a week or so after a public build release (happened on Monday).

Rob

josh_OneSignal · July 1, 2016, 6:19pm

@Rob Miracle Thanks for the fix!

Sounds like the OneSignal plugin should work fine after the next daily build. Let me know there is a compatibility change I can make for older builds or what triggered the bug.

nmichaud · July 2, 2016, 12:27pm

@Rob, thank you for the fix. We will try it as soon as the new daily build is available.

rob · July 2, 2016, 4:49pm

Just to be clear, the new daily build of Corona SDK won’t help you. The changes are in Enterprise and Josh will need to rebuild and upload a new plugin. After that you’re good to go.

Rob

jkasten · July 5, 2016, 11:56pm

@nmichaud Just push version 1.13.2 of the OneSignal SDK to fix the crash on current builds of Corona. It should be available in a few hours. This fully disables Android badges, we will bring it back in a future release for newer builds of Corona.