Widget 2.0: Tableview: "tap" event should not be sent if scrolling

If you tap the tableview to stop it from scrolling, a “tap” event is sent.

The first tap should only stop the tableview from scrolling without an event being sent.

But I would imagine that should only be the case if the scroll speed is > X – if it’s barely scrolling I think I’d want the tap to register. 

Partly because it seems really hard to stop the scroll and lift your finger up without it scrolling a little more. Maybe I just need to set the friction higher.

 Jay

I agree. There should be some sort of threshold value.

I’ve implemented this on my GitHub fork of Widget 2.0. Pull request issued.

This fix is to avoid accidental taps while trying to stop the scrolling of a tableview.

Do widget 2.0 allready open source?

Yep :smiley:https://github.com/coronalabs

Any ETA of merge?

Nothing is guaranteed to be merged/pulled in. We need to review all pull requests and decide whether they should be included or not.

Of course, but when that review will happen?

There are also no ETA’s on code reviews for pull requests. They will be done when possible.

I’m keeping two versions of the widget library on my system – one that’s “official” downloaded from CoronaLabs github repository, and one that’s “Frankenstein” made up of changes I and others have made to the widget framework. 

When CL releases a new version I’ll have to merge whatever they haven’t included to get my new “Frankenstein” version.

If you want fixes and changes that are being made, that’s probably what you’ll have to do. I don’t expect official updates any more often than we get new SDK releases. (If I’m wrong about that, good news for us!)

 Jay

Hi Jay,

That is a lot of work, but probably the only way.

Yeah, the problem is that I have to keep an “official” copy around for use when recording my tutorial videos – and I keep the “good” version around for when I’m writing my own apps. :wink:

 Jay

The idea is that the github repo will be kept up to date with the latest daily build widget version. So they will always be in sync

Yeah, but I use the last public release for my recordings and the daily builds for my own stuff – so I’m still keeping two copies of things around. :slight_smile:

 Jay

PS - But that’s good to know about the daily builds.

But I would imagine that should only be the case if the scroll speed is > X – if it’s barely scrolling I think I’d want the tap to register. 

Partly because it seems really hard to stop the scroll and lift your finger up without it scrolling a little more. Maybe I just need to set the friction higher.

 Jay

I agree. There should be some sort of threshold value.

I’ve implemented this on my GitHub fork of Widget 2.0. Pull request issued.

This fix is to avoid accidental taps while trying to stop the scrolling of a tableview.

Do widget 2.0 allready open source?

Yep :smiley:https://github.com/coronalabs