Banner in landscape showing as portrait :(

[TapForTapPhil]

I finally tracked down the interstitial bug and pushed a fix.

I have also extended the createAdView method to accept x and y offsets as well as a scale. The x and y offsets are from the top left corner of where you originally place the banner (ie. TOP + yOffset, CENTER + xOffset). Scale will grow the banner while maintaining the aspect ratio to keep the ad looking good (ie width and height get scaled by the same amount).

[lua]

createAdView(verticalAlignment, horizontalAlignment, xOffeset, yOffset, scale)

[\lua]

The offsets and scale are optional and if they are not provided the defaults are 0,0,1 so this change should not break existing code.

[WideAwakeGames]

@TapForTapPhil

I finally tracked down the interstitial bug and pushed a fix.

I have also extended the createAdView method to accept x and y offsets as well as a scale. The x and y offsets are from the top left corner of where you originally place the banner (ie. TOP + yOffset, CENTER + xOffset). Scale will grow the banner while maintaining the aspect ratio to keep the ad looking good (ie width and height get scaled by the same amount).

[lua]

createAdView(verticalAlignment, horizontalAlignment, xOffeset, yOffset, scale)

[\lua]

The offsets and scale are optional and if they are not provided the defaults are 0,0,1 so this change should not break existing code.

Nicely done. I must say the support response from tap to tap has been great. (cough Revmob not so much cough)

[WideAwakeGames]

@TapForTapPhil

I finally tracked down the interstitial bug and pushed a fix.

I have also extended the createAdView method to accept x and y offsets as well as a scale. The x and y offsets are from the top left corner of where you originally place the banner (ie. TOP + yOffset, CENTER + xOffset). Scale will grow the banner while maintaining the aspect ratio to keep the ad looking good (ie width and height get scaled by the same amount).

[lua]

createAdView(verticalAlignment, horizontalAlignment, xOffeset, yOffset, scale)

[\lua]

The offsets and scale are optional and if they are not provided the defaults are 0,0,1 so this change should not break existing code.

I just tested this on my Nexus S. My app is in landscaperight only. using TOP,CENTRE I still get the add in BOTTOM CENTRE.

[TapForTapPhil]

Sorry, I forgot to mention in my previous post that changes that I push are not instantaneous. They may take a day or two to make it into the Corona build system. The interstitial issue was something on Tap for Tap’s end (ie not in the plugin) so that fix got pushed right away.

I will add a way to get the version number of the plugin in the next update so when I push fixes you can check which version the Corna builder is using against what version I just pushed.

[WideAwakeGames]

@TapForTapPhil

Sorry, I forgot to mention in my previous post that changes that I push are not instantaneous. They may take a day or two to make it into the Corona build system. The interstitial issue was something on Tap for Tap’s end (ie not in the plugin) so that fix got pushed right away.

I will add a way to get the version number of the plugin in the next update so when I push fixes you can check which version the Corna builder is using against what version I just pushed.

OK, got it. 

[WideAwakeGames]

@TapForTapPhil

Sorry, I forgot to mention in my previous post that changes that I push are not instantaneous. They may take a day or two to make it into the Corona build system. The interstitial issue was something on Tap for Tap’s end (ie not in the plugin) so that fix got pushed right away.

I will add a way to get the version number of the plugin in the next update so when I push fixes you can check which version the Corna builder is using against what version I just pushed.

BTW, does Corona Labs tell you what daily build will have your fixes?

[DavidRangel]

WideAwakeGames - I may be misunderstanding, but 99% of the time, any changes to a plugin will be independent to daily builds. That’s one of the goals of plugins - to decouple the two.

[WideAwakeGames]

@DavidRangel

WideAwakeGames - I may be misunderstanding, but 99% of the time, any changes to a plugin will be independent to daily builds. That’s one of the goals of plugins - to decouple the two.

OK, that makes sense. So when Phil states that the push takes a while, I would assume that he’s checking in updated code in a versioning system for the plug-ins? If so, do the plug in devs know when their code updates are commited to production? Could there be a daily build summary for any plug-ins that have changed? I think that would be useful for both the plug-in dev and user.

[DavidRangel]

Yes, this is a good point (and we may already have something like this but not exposed). Let me look into it…