Just updated my Enterprise builds, and getting a deprecation error message

Corona Marketplace OneSignal
#1

I hadn’t updated Corona for a loooong time, to the point where I was still using a build that included notification in the core SDK.

I’m upgrading everything today, and I’ve grabbed the latest Enterprise build, and the latest plugin folder.

I’ve added the notification plugin, and switched all my local notification stuff over to use it, but when OneSignal is being used it says:

Android

09-17 15:10:29.448: I/Corona(10574): WARNING: /Users/Kasten/Documents/OneSignal/GameThrive/SDK/Corona/SDK/android/../shared/plugin\_OneSignal.lua:94: system.cancelNotification: This function has been deprecated, use 'plugin.notifications' instead.

iOS

Sep 17 14:22:03 iPad QuizTix[370] \<Warning\>: WARNING: /Users/Kasten/Documents/OneSignal/GameThrive/SDK/Corona/SDK/shared/plugin\_OneSignal.lua:94: system.cancelNotification: This function has been deprecated, use 'plugin.notifications' instead.

I’m using the OneSignal files from the latest Corona plugins folder, so can anyone at OneSignal let me know what is happening here?

Thanks

#2

Hello Alan,

Our OneSignal SDK is still using the old Corona function to clear notifications when you call OneSignal.ClearAllNotifications(). We will be moving to using full native code for this method in a future update to remove the warning.

Thanks.

#3

Ok, thanks for letting me know.

#4

Is it possible to make a small request?  

After updating from the old GameThrive lib to the OneSignal lib (on iOS), I had a duplicate symbol error which prevented me from building. 

The variable in question is called “_VERSION”, I’m presuming this holds the SDK version number or something. Is there any way this could be renamed to “ONESIGNAL_VERSION” or something else unique in future releases? I will ask the developer of the other SDK, but the OneSignal team seem to be much more responsive so I’m not expecting the other developer to actually do it.

Failing that, do you know a way around the duplicate symbol error? In the past I tried removing the “-all_load” but that caused huge problems (the main one being that it prevented Enterprise building the app).

I’ve read that you can use lipo to combine the 2 libs into one, but in that case only one of the symbols is preserved and would be used for both libs which isn’t ideal.

Tbh it’s always seemed odd to me that the variable are not trated as being fully contained in their own libs, but don’t know enough about the build structure to comment on that.

#5

Hello,

We will be submitting an update to Corona soon that includes a fix for this. Instead of waiting for the update to become available you can download it here now.

https://www.dropbox.com/s/iop9dllt0w2996h/OneSignal_CoronaEnterprise1.10.3.zip?dl=0

Thanks.

#6

Grade A service as always :slight_smile:

I’ll try that out on Monday and let you know if all is OK.

#7

Hello Alan,

Our OneSignal SDK is still using the old Corona function to clear notifications when you call OneSignal.ClearAllNotifications(). We will be moving to using full native code for this method in a future update to remove the warning.

Thanks.

#8

Ok, thanks for letting me know.

#9

Is it possible to make a small request?  

After updating from the old GameThrive lib to the OneSignal lib (on iOS), I had a duplicate symbol error which prevented me from building. 

The variable in question is called “_VERSION”, I’m presuming this holds the SDK version number or something. Is there any way this could be renamed to “ONESIGNAL_VERSION” or something else unique in future releases? I will ask the developer of the other SDK, but the OneSignal team seem to be much more responsive so I’m not expecting the other developer to actually do it.

Failing that, do you know a way around the duplicate symbol error? In the past I tried removing the “-all_load” but that caused huge problems (the main one being that it prevented Enterprise building the app).

I’ve read that you can use lipo to combine the 2 libs into one, but in that case only one of the symbols is preserved and would be used for both libs which isn’t ideal.

Tbh it’s always seemed odd to me that the variable are not trated as being fully contained in their own libs, but don’t know enough about the build structure to comment on that.

#10

Hello,

We will be submitting an update to Corona soon that includes a fix for this. Instead of waiting for the update to become available you can download it here now.

https://www.dropbox.com/s/iop9dllt0w2996h/OneSignal_CoronaEnterprise1.10.3.zip?dl=0

Thanks.

#11

Grade A service as always :slight_smile:

I’ll try that out on Monday and let you know if all is OK.