last version of zip(2020.3627) not working correctly on Android

[StarCrunch]

@redbol Could you try it with these builds?

zip.zip (1.1 MB)

If you’ve not already done so, set up the file structure described here, so Solar2DPlugins → com.coronalabs → plugin.zip → (platforms) → data.tgz.

There were problems with the directories. These are even slightly random, it seems. It’s possible it was broken before but the earlier Android zlib was letting it go; that’s my best guess.

If this seems to be better I’ll try to submit a new version on Monday.

I’ve been on a wild goose chase trying to chase down some weird file bug that was getting in the way of Windows testing, so didn’t send this earlier.

[vlads]

Easiest way is to download required tgz and replace it inside Caches directory in Solar2DPlugins.

Releases · coronalabs/com.coronalabs-plugin.zip

[redbol]

Ye that what I did… But also Compiling of .apk will start update Caches directory in Solar2D Plugins with latest versions automatically.

[redbol]

Uncompress function working correct on both platforms! Thank you so much!

There another report with your builds(zip.zip (1.1 MB)):
AndroidEmu(no error) and Win(still do not compression):

[vlads]

Hey! I rebuild a zip plugin with older SDK. Please, check if it works for you
(replage data.tgz with this file).
I will release this one soon.

920.8 KB file on MEGA

[redbol]

As I understand it, I had to drop your build into an empty folder “Solar2DPlugins\com.coronalabs\plugin.zip\android”.
AndroidEmulator - error, Win - ok

[vlads]

I uploaded version to the repository. Just delete whole Solar2DPlugins directory to get the latest

[redbol]

Oke, i did. But i get same result

[StarCrunch]

@redbol Could you try again with this (Windows) build?

data.tgz (39.1 KB)

Also, you might want to manually remove any files from your documents / temporary directories first.

You might have been seeing the effects of “some weird file bug that was getting in the way of Windows testing”, especially if you had relaunched. (I’m not sure why I didn’t see it in your test; maybe one of us adapted it in the meantime.)

I just found a major issue: list() never closes the zip file, so clearFiles(true) can’t remove it. I’m still not quite sure why this was breaking compress() on my end (rather than just piling up entries), but fixing that seems to have addressed it.

(I left some debug info in my last build by mistake–those “O?” and “!!!” you see–but on purpose this time, in case you get an error and show another image. If not I’ll try to get another PR together later.)

[redbol]

I put yout build in “Solar2DPlugins\plugin.zip\win32-sim”
Deleted all files and folders in temporary directories of App
Run App, got this:

Oke, nothing changed…

After i deleted folder “Solar2DPlugins\plugin.zip”. Deleted all files and folders in temporary directories of App.
Put your new build in “Corona Simulator\Plugins\plugin.zip” and extract “plugin_zip.dll” from “data.tar” in “Corona Simulator\Plugins”. Run App:

But im not sure, what do You wanna test, bcs all works on Win

[StarCrunch]

Ah, I should have mentioned that you can delete catalog.json to force an update.

Anyhow, that’s good! My last build (before Vlad’s) was where compression was failing. I’ll try to get these changes cleaned up later and submitted.

[vlads]

Made another build. It is up now, please try.

[redbol]

All works on Android

[planzieri]

Confirm, Android now all OK! On Mac.
Thank you so much
Pasquale

[umalemon]

I have the same problem.
Running zip.uncompress doesn’t finish.
There was no problem a few days ago.
Deleting plugin.zip or deleting catalog.json does not solve the problem.

---

local options = {
zipFile = filename,
zipBaseDir = system.TemporaryDirectory,
dstBaseDir = system.DocumentsDirectory,
listener = zipListener,
}
zip.uncompress( options )
---- event.respone ----
12:00:20.970 – event.name:zip
12:00:20.970 – event.type:uncompress
12:00:21.759 – event.name:zip
12:00:21.759 – event.type:uncompress
12:00:22.544 – event.name:zip
12:00:22.544 – event.type:uncompress
12:00:23.312 – event.name:zip
12:00:23.312 – event.type:uncompress
12:00:24.096 – event.name:zip
12:00:24.096 – event.type:uncompress
12:00:24.883 – event.name:zip
12:00:24.883 – event.type:uncompress
12:00:25.660 – event.name:zip
12:00:25.660 – event.type:uncompress
12:00:26.445 – event.name:zip
12:00:26.445 – event.type:uncompress
12:00:27.228 – event.name:zip
12:00:27.228 – event.type:uncompress
12:00:28.025 – event.name:zip
12:00:28.025 – event.type:uncompress
12:00:28.809 – event.name:zip
12:00:28.809 – event.type:uncompress
12:00:29.589 – event.name:zip
12:00:29.589 – event.type:uncompress
…loop

Zip sample
https://magnum.sublogics.com/kh416c.zip

[umalemon]

plugin.zip
2020.3627 : error(cant finish)
2020.3590 : success
It seems to be a problem of 2020.3627.
Does that mean there is a newer, modified version?

[umalemon]

The new plugin.zip doesn’t seem to unzip the empty directory.
images, images_custom, sounds are compressed in hk416c, but empty images_custom is ignored.
If you unzip it with Windows winzip, you can see that it contains 3 folders, but with the new plugin.zip it is 2.
The 2020.3590 plugin.zip correctly contains three folders.

I check the contents of the folder after uncompress is done. If it wasn’t enough, I was running uncompress again. (Sorry, I forget it myself.)
I told you I was looping, but not because of plugin.zip, but because of my check logic.
The reason for this is that previous, very old versions sometimes did not completely uncompress at one time.

[StarCrunch]

@umalemon Sorry I’ve taken so long. Just a bit distracted and a little burned out by this.

I think I have something functional (this is just Windows and Android):
data.zip (1.1 MB)

These are very noisy with debug printouts. If it looks okay, I’ll try to make a clean build soon.

(Save your other data.tgz files first, or re-grab them from Discord afterward.)

---

@redbol @planzieri Could I pester you in the same way, just to make sure these aren’t regressions?

Apologies for all this hassle.

[redbol]

win:

android:

[umalemon]

Thank you for your work.
I’ve tried it on Windows and Android and it works fine.
An empty folder was also included.